Hi Sami, On Wednesday 07 May 2014, Sami Kerola wrote: > [PATCH] tests: make kill to go-around when /proc is not available Do you really want to get it work when whole /proc is not available or just if /proc/$pid/status is still missing? > And change messaging to be easier to debug, if the outcome of the > opportunistic sleep is unsuccessful test. In such case one could > assume the test_sigreceive was not successful when setting handler. > Maybe because of load on test server, or some other reason. > > Reference: https://travis-ci.org/rudimeier/util-linux/jobs/24561058 > Signed-off-by: Sami Kerola <kerolasa@xxxxxx> > --- > tests/ts/kill/kill_functions.sh | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/ts/kill/kill_functions.sh > b/tests/ts/kill/kill_functions.sh index 043b4cb..56ad98b 100644 > --- a/tests/ts/kill/kill_functions.sh > +++ b/tests/ts/kill/kill_functions.sh > @@ -5,6 +5,16 @@ function check_test_sigreceive { > local pid=$1 > > for i in 0.01 0.1 1 1 1 1; do > + if [ ! -f /proc/$pid/status ]; then > + # This message is visible in tests/run.sh output. > + # Do not direct to $TS_OUTPUT it would make test > + # fail, while with a bit of luck this might be > + # recoverable (after a sleep). How could the test still succeed if we break the loop and return 1? In this case the particular tests usually write "helper did not start" to $TS_OUTPUT. > + echo "kill_functions.sh: /proc/$pid/status: No such file or directory" && > + rc=1 && Shouldn't we return 0 here ... > + sleep 2 && > + break ... or only continue the loop to hope that /proc/$pid/status will be there next round? > + fi > awk 'BEGIN { retval=1 } > /^SigCgt/ { > lbyte = strtonum("0x" substr($2, 16, 16)) cu, Rudi -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
