On 14 April 2014 17:14, Bernhard Voelker <mail@xxxxxxxxxxxxxxxxxxx> wrote: Hi Berny, > Looking quickly at the tests, I think I don't understand the idea behind > all that symlinking stuff. I mean for most test cases it would suffice > to kill with the PID instead of the process name. > > Re. the test failures of name_to_number: when I change the kill command > to work on $TEST_PID instead of the symlink name, then I don't get the > failures anymore. Most of the tests could use pid, but I am afraid there should be at least one of them using name. Else killing by name remains untested. Of course simple kill by name test could do the job, but I am not hugely in favor to simplify tests until they work without understanding why they fail in first place. > BTW: is there a reason why you stick to using $(jobs -p) to get the > TEST_PID instead of the much simpler "$!"? Not any other reason than I did not know about "$!", which indeed is better expression. Thank you for tip, I will push the better version to v2 branch. -- Sami Kerola http://www.iki.fi/kerolasa/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
