Re: [PATCH] blockdev(8): Some minor corrections to the manual

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3 April 2014 00:23, Bjarni Ingi Gislason <bjarniig@xxxxxxxxx> wrote:
>   Patch is in the attachment

Hi Bjarni,

Great to see new contributor.

It seems you are sending quite a few patches, and it would be better
to get them in git native format. Looking your message I think you
have downloaded release package, made changes and used 'diff -u'.
That's not too bad when sending a small number of changes. To me your
number your patches is exceeding what I would describe as small
number.

Could you get yourself a clone of this project. Configure your git,
and resubmit.

git clone git://git.kernel.org/pub/scm/utils/util-linux/util-linux.git
util-linux
git config --global user.name "Bjarni Ingi Gislason"
git config --global user.email bjarniig@xxxxxxxxx
git branch bjani
git checkout bjarni
# while patches {
git apply <each of your patch separately>
git add .
git commit -s
# }

# create patches
git format-patch -n master ~/ul-patches/

# test that you can send/receive emails
git send-email --to bjarniig@xxxxxxxxx ~/ul-patches/*
# if yes, and all looks good
git send-email --to util-linux@xxxxxxxxxxxxxxx ~/ul-patches/*

If you end struggling with email for hours it might be easier to save
all files in ul-patches directory to a single tar.gz file, and send it
as an attachment. This is not quite as good as seeing patches in email
list as message body, but at least the patches would be in easy to
process format.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux