Re: [PATCH 03/10] kill: flip all comparions to be in smaller - greater order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 9, 2014, at 21:30, Sami Kerola wrote:
> This makes code more readable.

Hmm, I don't agree with that.

> -			if (argc > 2)
> +			if (2 < argc)

> -	if (num < SIGRTMIN || num > SIGRTMAX)
> +	if (num < SIGRTMIN || SIGRTMAX < num)

I like to see always the variable on the left and the fixed value on the right.

Regards,

Benno

-- 
http://www.fastmail.fm - Send your email first class

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux