Re: [PATCH 06/10] kill: leeway deprecation of --pid invocation as command name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/09/2014 09:30 PM, Sami Kerola wrote:
> diff --git a/misc-utils/kill.c b/misc-utils/kill.c
> index 2fecda3..11c8cd2 100644
> --- a/misc-utils/kill.c
> +++ b/misc-utils/kill.c
> @@ -170,6 +170,8 @@ int main(int argc, char **argv)
>  
>  	numsig = SIGTERM;
>  	do_pid = (!strcmp(program_invocation_short_name, "pid"));	/* Yecch */
> +	if (do_pid)
> +		warnx(_("use of 'kill --pid' option as command name will be deprecated in future"));

You deprecate now:
  s/will .* future/is deprecated/


Another minor note:
Shouldn't there be something like a

  +  /* FIXME: remove in March 2016.  */

together with deprecations like that?
It would be easier to find and fix then.

Have a nice day,
Berny
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux