I just sent out fixed patches, but for some reason they went to the main list (I think I needed `git send-email --thread`). Sorry for that. Now `fdisk` binary falls back to retrying `fdisk_context_assign_device` with `readonly == 1` and warns user about it. On Mon, Mar 3, 2014 at 10:04 AM, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Fri, Feb 28, 2014 at 02:18:24PM -0500, Phillip Susi wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 2/28/2014 1:27 PM, Davidlohr Bueso wrote: >> >> You really want to tell the user that they aren't going to be >> >> able to write up front. >> > >> > Sure why not, just not in a library! You can do this in the fdisk >> > program. And if Karel doesn't agree and wants to apply this patch >> > anyway, then it should *at least* be in DBG context. >> >> Right, which is what I said just after that ;) > > I'll try to improve the function after libfdisk branch merge into > master branch (this or next week). The current code is probably > really not optimal. > > Karel > > -- > Karel Zak <kzak@xxxxxxxxxx> > http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
