On Fri, Feb 14, 2014 at 02:30:59PM +0100, Karel Zak wrote:
> On Fri, Feb 14, 2014 at 01:07:53PM +0000, Rodrigo Campos wrote:
> > On Fri, Feb 14, 2014 at 11:47:56AM +0100, Karel Zak wrote:
> > > > + for (off_t offset = 0; offset + hole_size <= end; offset += buf_len) {
> > > ^^^^^^^^^^^
> > >
> > > Yes it's expected by C standards, but it sucks. Don't use it, it's
> > > reader's nightmare.
> >
> > Ohh, I didn't know. Can I ask why ?
> >
> > And what type should I use ? loff_t ? Why is this better ?
> >
> > (just curious, I want to understand :))
>
> Ah, my mistake.. I have no talked about "off_t", but about variables
> declarations. It's always better to have declarations at the begin of
> the code block or function.
>
> for (int i = 0; ... )
>
> is C++ism that for unknown crazy reason has been accepted by C
> compilers/standards (C99).
Ohh, sorry, my bad. I see you already fixed it also, thanks! :)
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
