On Tue, 14 Jan 2014, Karel Zak wrote: > On Mon, Jan 13, 2014 at 03:32:49PM -0500, Scott Moser wrote: > > partx --update DEVICE NUMBER > > was broken in 2 cases: > > * if NUMBER != 1 > > * if the partition table was "out of order". > > Ie, where sda2 came after sda3. > > > > fixes http://pad.lv/1244662. > > See bug for example recreates. > > Good catch. > > > - for (i = 0, n = lower; n <= upper; n++) { > > - par = blkid_partlist_get_partition(ls, i); > > - an = blkid_partition_get_partno(par); > > - > > - if (lower && n < lower) > > - continue; > > - if (upper && n > upper) > > > It was really stupid code :-( > > Applied, thanks! > > > You forgot "Signed-off-by: ", I have fixed this mistake before commit > as I guess you agree with this change. OK? I agree. Thanks. Signed-off-by: Scott Moser <smoser@xxxxxxxxxx> Scott -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
