On 18 December 2013 22:32, Dale R. Worley <worley@xxxxxxxxxxxx> wrote:
> (My understanding is that this is the correct place to report bugs for
> util-linux.)
Hi Dale,
Correct. You reached right audience.
> In the manual page for losetup (in util-linux-2.23.2-4.fc19.x86_64) is
> the text:
>
> Setup loop device:
>
> losetup [-o offset] [--sizelimit size]
> [-p pfd] [-rP] {-f[--show]|loopdev} file
>
> However, the "-p" option is not described in the text.
>
> There also should be a space after "-f".
That help output looks a little old. Never the less the point about
manual page not informing the --pass-fd not being supported is valid.
Karel, sorry about the attachment. Mail relays in the office are git
send-email hostile.
--
Sami Kerola
http://www.iki.fi/kerolasa/
From 1ec7f343d460f702f79c39538025ef6fca0548c7 Mon Sep 17 00:00:00 2001
From: Sami Kerola <sami.kerola@xxxxxxxxx>
Date: Thu, 19 Dec 2013 09:41:18 +0000
Subject: [PATCH] losetup: mention in manual page --pass-fd is not supported
Organization: lastminute.com
And suppress warn() errno conversion to 'Success' that does not make
sense.
Signed-off-by: Sami Kerola <sami.kerola@xxxxxxxxx>
---
sys-utils/losetup.8 | 2 ++
sys-utils/losetup.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/sys-utils/losetup.8 b/sys-utils/losetup.8
index c61a61e..1099210 100644
--- a/sys-utils/losetup.8
+++ b/sys-utils/losetup.8
@@ -122,6 +122,8 @@ option and a
argument are present.
.IP "\fB\-v, \-\-verbose\fP"
verbose mode
+.IP "\fB\-p, \-\-pass-fd\fP \fIfile descriptior\fP"
+This option is no longer supported.
.SH ENCRYPTION
.B Cryptoloop is no longer supported in favor of dm-crypt. For more details see
diff --git a/sys-utils/losetup.c b/sys-utils/losetup.c
index 70d9155..7708fd9 100644
--- a/sys-utils/losetup.c
+++ b/sys-utils/losetup.c
@@ -538,7 +538,7 @@ int main(int argc, char **argv)
list = 1;
break;
case 'p':
- warn(_("--pass-fd is no longer supported"));
+ warnx(_("--pass-fd is no longer supported"));
break;
case 'P':
lo_flags |= LO_FLAGS_PARTSCAN;
--
1.8.5.2
