While most disk partitioning tools out there create a pMBR's size in lba to be the lesser of the whole disk or 2Tib, Microsoft apparently does not[1]. It always sets the entry to the maximum 32-bit limitation - even though a drive may be smaller than that. Loosen this check and only verify that the size is either the whole disk or 0xFFFFFFFF. No tool in its right mind would set it to any value other than these. [1] http://thestarman.pcministry.com/asm/mbr/GPT.htm#GPTPT Signed-off-by: Davidlohr Bueso <davidlohr@xxxxxx> --- libfdisk/src/gpt.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libfdisk/src/gpt.c b/libfdisk/src/gpt.c index bb9e9a7..83659cb 100644 --- a/libfdisk/src/gpt.c +++ b/libfdisk/src/gpt.c @@ -477,6 +477,7 @@ static int valid_pmbr(struct fdisk_context *cxt) { int i, part = 0, ret = 0; /* invalid by default */ struct gpt_legacy_mbr *pmbr = NULL; + uint32_t sz_lba = 0; if (!cxt->firstsector) goto done; @@ -517,12 +518,15 @@ check_hybrid: /* * Protective MBRs take up the lesser of the whole disk * or 2 TiB (32bit LBA), ignoring the rest of the disk. + * Some partitioning programs, nonetheless, choose to set + * the size to the maximum 32-bit limitation, disregarding + * the disk size. * * Hybrid MBRs do not necessarily comply with this. */ if (ret == GPT_MBR_PROTECTIVE) { - if (le32_to_cpu(pmbr->partition_record[part].size_in_lba) != - min((uint32_t) cxt->total_sectors - 1, 0xFFFFFFFF)) + sz_lba = le32_to_cpu(pmbr->partition_record[part].size_in_lba); + if (sz_lba != (uint32_t) cxt->total_sectors - 1 && sz_lba != 0xFFFFFFFF) ret = 0; } done: -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
