On Sat, Sep 14, 2013 at 05:59:24PM +0200, Gabriel de Perthuis wrote:
> > Log incorrect checksums and stop the superblock probing loop when
> > one is encountered.
> > This is to avoid exposing backend devices that are supposed
> > to be used through a stacked device (like raid or bcache).
>
> Sorry, but some of the changes you made when applying break the patch.
> The intent is to stop the probing loop when a bad container is encountered;
> the contents shouldn't be scanned.
Why? This is unwanted behaviour. If there is incomplete (broken)
superblock we continue with probing to check for another superblock.
This is very basic libblkid feature.
It's pretty common that there is old obsolete superblock, but user
expects a new superblock after mkfs. Unfortunately not all mkfs-like
programs wipe devices.
Do you think that the content in the bad bcache could be interpreted
as regular filesystem? I don't think so.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
