On Tue, Sep 03, 2013 at 08:15:18AM +0100, Sami Kerola wrote:
> On 3 September 2013 00:22, Dave Reisner <d@xxxxxxxxxxxxxx> wrote:
> > A little late to the game, but this commit breaks the return value of
I'm happy that you play the game with us, better later than never :-)
> > hexdump and causes it to always return 1, even on successful invocation.
> > next(char**) will always return 1 for the usual (non-NULL) values of argv.
>
> You are not late at all. Thanks to you broken hexdump was never
> released to greater audience. I'll fix the issue in near future,
> unless someone else is quicker.
BTW, Ondrej Oprala is working on hexdump refactoring for v2.25 (for
v2.24 is too late). So, I hope that one day we will have more
readable and maintainable code.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
