Re: [PATCH 15/17] last: use configuration struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2013 at 07:06:17PM +0100, Sami Kerola wrote:
> +	struct last_control ctl;
> +	int c;
>  	usec_t p;
>  
>  	static const struct option long_opts[] = {
> @@ -761,6 +775,11 @@ int main(int argc, char **argv)
>  	      { NULL, 0, NULL, 0 }
>  	};
>  
> +	memset(&ctl, 0, sizeof(struct last_control));
> +	ctl.showhost = TRUE;
> +	ctl.name_len = LAST_LOGIN_LEN;
> +	ctl.domain_len = LAST_DOMAIN_LEN;
> +

  struct last_control ctl = {
         .showhost = TRUE,
         .name_len = LAST_LOGIN_LEN,
         .domain_len = LAST_DOMAIN_LEN
  };

 is good enough, memset() is unnecessary.


    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux