* Karel Zak (kzak@xxxxxxxxxx) wrote: > On Thu, Aug 01, 2013 at 01:57:03PM +0100, Dr. David Alan Gilbert wrote: > > e to > > > reproduce the problem with the file from Suse bugzilla). > > > > Hi Karel, > > Thanks for the reply. I'll give it a go over the weekend, > > but I don't think it can handle the wchar problems I described and fixed > > in my follow up patch. If a 4byte wchar hapens to land at the end of the buffer > > how do you guarantee the space? > > Ah, I probably see what you mean. So I have added p < &Line[LineLen - 1] > check to the for() where the code copies the multibyte buffer to line buffer. > See git tree for more details. OK; so I think with your ...ea608842 change then it should work (not tried to push it); but with that change hopefully the extra check in ..623bc74f should never trigger; which is good because if it does then I think you'll end up outputing part of a wide character which would get messy. One thing I tried to do in my change was remove the magic '4's that pop up in a few places because of the wide characters. (Any particular reason you prefered this over my fix?) Dave > > Karel > > > > -- > Karel Zak <kzak@xxxxxxxxxx> > http://karelzak.blogspot.com -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ gro.gilbert @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
