[PATCH 04/34] hexdump: use unlocked io, and avoid use of printf()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This makes common cases about 35-50% quicker.

Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
---
 text-utils/display.c   | 11 ++++++-----
 text-utils/hexsyntax.c |  1 +
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/text-utils/display.c b/text-utils/display.c
index 41ddd8d..21a59c2 100644
--- a/text-utils/display.c
+++ b/text-utils/display.c
@@ -39,6 +39,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include "unlocked-io.h"
 #include "hexdump.h"
 #include "xalloc.h"
 #include "c.h"
@@ -110,13 +111,13 @@ print(PR *pr, unsigned char *bp) {
 		break;
 	    }
 	case F_P:
-		(void)printf(pr->fmt, isprint(*bp) ? *bp : '.');
+		putchar(isprint(*bp) ? *bp : '.');
 		break;
 	case F_STR:
 		(void)printf(pr->fmt, (char *)bp);
 		break;
 	case F_TEXT:
-		(void)printf("%s", pr->fmt);
+		fputs(pr->fmt, stdout);
 		break;
 	case F_U:
 		conv_u(pr, bp);
@@ -213,7 +214,7 @@ void display(void)
 				(void)printf(pr->fmt, (int64_t)eaddress);
 				break;
 			case F_TEXT:
-				(void)printf("%s", pr->fmt);
+				fputs(pr->fmt, stdout);
 				break;
 			}
 	}
@@ -250,7 +251,7 @@ get(void)
 			if (!need && vflag != ALL &&
 			    !memcmp(curp, savp, nread)) {
 				if (vflag != DUP)
-					(void)printf("*\n");
+					fputs("*\n", stdout);
 				return(NULL);
 			}
 			if (need > 0)
@@ -281,7 +282,7 @@ get(void)
 				return(curp);
 			}
 			if (vflag == WAIT)
-				(void)printf("*\n");
+				fputs("*\n", stdout);
 			vflag = DUP;
 			address += blocksize;
 			need = blocksize;
diff --git a/text-utils/hexsyntax.c b/text-utils/hexsyntax.c
index 2910ca5..a97ce11 100644
--- a/text-utils/hexsyntax.c
+++ b/text-utils/hexsyntax.c
@@ -43,6 +43,7 @@
 #include <err.h>
 #include <limits.h>
 #include <getopt.h>
+#include "unlocked-io.h"
 #include "hexdump.h"
 #include "nls.h"
 #include "strutils.h"
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux