Re: [PATCH 08/15] dmesg: convert time format bitfield to enum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 16, 2013 at 07:53:49PM +0100, Sami Kerola wrote:
> +#define is_timefmt(c, f) (c->time_fmt == (DMESG_TIMEFTM_ ##f))

[...]

> +#undef is_timefmt
> +#define is_timefmt(c, f) (c.time_fmt == (DMESG_TIMEFTM_ ##f))

 Don't be lazy to use &ctl in code. You want to write readable and
 maintainable code ;-)

 Fixed.

    Karel

 Always code as if the person who ends up maintaining your code is a
 violent psychopath who knows where you live.
                         http://c2.com/cgi/wiki?CodeForTheMaintainer
-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux