Re: [PATCH 15/15] hexdump: use simple printing functions when possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 16, 2013 at 07:53:56PM +0100, Sami Kerola wrote:
> This makes common cases 35-50% quicker.

 What about portability and code readability?

 It would be nice to have include/unlocked-io.h and add 
 AC_CHECK_DECLS_ONCE() for all *_unlocked functions. 

 See gnulib/lib/unlocked-io.h
     gnulib/m4/unlocked-io.m4

 .. then you can control all the behaviour by "#include unlocked-io.h"
 rather than change all the code in the util(s). Maybe we can use the
 functions in more utils where we intensively print something (e.g.
 dmesg).

 I guess we don't want separate m4 file for this stuff.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux