Re: [PATCH 04/19] sfdisk: use libc error printing function, and symbolic exit values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 02, 2013 at 06:51:10PM +0100, Sami Kerola wrote:
>      if ((out = lseek(fd, in, SEEK_SET)) != in) {
>  	perror("lseek");
> -	error(_("seek error on %s - cannot seek to %lu\n"), dev, s);
> +	warnx(_("seek error on %s - cannot seek to %lu"), dev, s);
>  	return 0;

 I don't think that perror() + warnx() is elegant solution, just use
 warn() only.

 warn(_("seek failed %s" - cannot seek to %lu"), dev, s);

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux