On Wed, May 29, 2013 at 08:23:53PM +0200, Benno Schulenberg wrote:
> The first patch standardizes the usage message of 'login' to the use of
It would be nice to have a real usage() function in login.c.
> angular brackets, the second standardizes the spelling of "super-user"
> to the more common "superuser", the third makes a minor tweak, and
> in the fourth patch I got carried away and reviewed all the comments
> in login.c -- if this is too much, I can redo the patch to contain just the
> grammar and typo fixes ("accout", "reinilizalize", ...).
It's OK to fix stupid typos and grammar mistakes in comments, but it's
probably overkill to clean up all comments in all utils.
It's usually better to do such massive changes together with code cleanup
(or after code cleanup). We recently did code refactoring in login,
eject, mount, umount, sulogin, cal, whereis, dmesg, etc.
The new code is also in lsblk, findmnt, lscpu, lslocks, prlimit, ...
But for now don't waste time with things like fdisk, hexdump, hwclock, etc.
Applied, thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
