On 6 May 2013 01:11, Pádraig Brady <P@xxxxxxxxxxxxxx> wrote: Hi Pádraig, > I'd have it as an optional arg, defaulting to auto. Good point. That would result to more consistent interface, which is a virtue in itself. >> + case HIGHLIGHT_ALWAYS: >> + if (day == 0) >> + day = local_time->tm_yday + 1;; > > s/;;/;/ shellism :) Oops, I will push a fix to my git within next 48 hours. I have slight problem with my programming environment at the moment which I need to sort out first. >> + break; >> + default: >> + abort(); >> + } >> >> if (yflag) >> yearly(day, year, julian); >> > > s/highligth/highlight/ in the subject line Oh dear, me and my finglish. > Also I'd s/--highlight/--color/ to align with dmesg and other utils. > Only highlighting is done at present, but that could be set up > to use color in the user's environment. Also in future other parts > of the output could be colored etc. > > BTW, dmesg could get the same support for specifying "always" and "never". Karel earlier mentioned the same, and I wrote some sort of change which will add --when to dmesg. Allowing user to choose dmesg colors etc highlights using facilities & priorities as criteria would probably be quite neat feature. -- Sami Kerola http://www.iki.fi/kerolasa/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
