On Sun, Jan 20, 2013 at 10:56 AM, Benno Schulenberg
<bensberg@xxxxxxxxxxxxx> wrote:
> Attached set of patches I had still lying around. They have been
> rebased against current origin.
>
> The first three patches improve the wording or consistency of some
> help texts and error messages. The fourth patch gettextizes several
> overlooked translatable strings, and improves some of them and some
> related others. The fifth patch standardizes the reporting of the
> program name to "name from util-linux". The sixth patch improves
> the synopsis of renice to re-include the long option names and also
> improves the help text. Finally, the seventh patch makes renice
> recognize also -V for --version (instead of just -v), documents it,
> and in the bargain improves the man page.
Hi Benno,
There is lots of good stuff in these patches, but as usual some things
could be bit better. For example the version strings which you wrote
to format
+ fprintf(stderr, _("%s from %s\n"),
+ program_invocation_short_name, PACKAGE_STRING);
should use UL version printing macro.
+ fprintf(stderr, UTIL_LINUX_VERSION);
In the patch 0007 the renice(1) adds -V short option along side with
-v to print version. IMHO if the upper case option is added the lower
case equivalent should be dropped.
--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
