On 23 October 2012 17:46, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Mon, Oct 22, 2012 at 10:27:23PM +0530, Venkatraman S wrote: >> Venkatraman S (4): >> libblkid/topology: add preferred_erase_size to topology probe >> mkswap: refactor header preparation >> mkswap: Add additional fields in swapheader >> mkswap: Probe and embed useful block device info into swapheader > > I don't see a problem to support additional information in the swap > header, but our rule is pretty simple: first in Linus' tree, after > that in userspace. > Thanks Karl - that's understood. I posted the patches to better explain the issue I faced - this new parameter I introduced in topology.c is accessible only when I pass the root disk dev node to mkswap (as /dev/mmcblkX) and not when invoked with /dev/mmcblkXpY) (i.e a partition with the device). So how should the topology probe be invoked in this case ? Thanks, Venkat. -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html