Re: [PATCH] Use C99 idioms in kill.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Oct 18, 2012 at 03:52:30PM +0000, Ayan George wrote:
> * Moved some declarations closer to where the vairable is used.
> * Declared variables used only in loops within the loop itself.
> ---
>  misc-utils/kill.c |   45 +++++++++++++++++++--------------------------
>  1 file changed, 19 insertions(+), 26 deletions(-)
> 
> diff --git a/misc-utils/kill.c b/misc-utils/kill.c
> index 6abfd24..2b88852 100644
> --- a/misc-utils/kill.c
> +++ b/misc-utils/kill.c
[...]
> -    numsig = SIGTERM;
> -    do_pid = (! strcmp (progname, "pid")); 	/* Yecch */
> -    do_kill = 0;
> -    check_all = 0;
> +    int numsig = SIGTERM,
> +    	do_pid = (! strcmp (progname, "pid")), 	/* Yecch */
> +    	do_kill = 0;
> +    	check_all = 0;

Please enable your .git/hooks/pre-commit to stop these whitespace errors,
no matter whether to use C99 or not.


-- 
ldv

Attachment: pgp42qOq8dElk.pgp
Description: PGP signature


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux