On Sun, Oct 14, 2012 at 11:10 PM, Dave Reisner <d@xxxxxxxxxxxxxx> wrote: > On Sun, Oct 14, 2012 at 09:20:58PM +0100, Sami Kerola wrote: >> [misc-utils/sd-daemon.c:91]: (style) Checking if unsigned variable 'l' is \ >> less than zero. >> [misc-utils/sd-daemon.c:254]: (warning) Comparison of a boolean \ >> expression with an integer. >> [misc-utils/sd-daemon.c:363]: (style) Checking if unsigned variable \ >> 'length' is less than zero. >> [misc-utils/sd-daemon.c:366]: (style) Checking if unsigned variable \ >> 'length' is less than zero. >> >> Signed-off-by: Sami Kerola <kerolasa@xxxxxx> >> --- >> misc-utils/sd-daemon.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/misc-utils/sd-daemon.c b/misc-utils/sd-daemon.c >> index 763e079..21399e2 100644 >> --- a/misc-utils/sd-daemon.c >> +++ b/misc-utils/sd-daemon.c > > This file comes directly from the systemd tree. I think it'd be better > to submit the fix there first. > > Either way, there's whitespace errors in this patch (tabs rather than > spaces). Hi Dave, OK, I will send the patch there and remove it from my branch. Thank you for review. -- Sami Kerola http://www.iki.fi/kerolasa/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
