Re: [PATCH 03/13] ipcs: determine ipc limits from /proc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 14 October 2012 16:22:15 Sami Kerola wrote:
> +		fscanf(f, "%d", &(lim->msgmni));

no need for the paren around lim->msgmni.  same thing applies many times in 
this patch.

> +	if ((msgctl(0, IPC_INFO, (struct msqid_ds *)(void *)&msginfo)) < 0)

the paren around msgctl doesn't make sense.  seems like you do this multiple 
times in this patch and none of them make sense.

> +	lim->msgmni = (int)msginfo.msgmni;
> +	lim->msgmnb = (int)msginfo.msgmnb;

these casts don't make sense.  they're both ints.

> +	lim->msgmax = (size_t)msginfo.msgmax;

msgmax is an int, so it seems like blindly casting to size_t isn't a good 
idea.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux