Use the sysconf(_SC_HOST_NAME_MAX) to determine maximum length of a
hostname.
Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
---
term-utils/write.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/term-utils/write.c b/term-utils/write.c
index 6c746b4..29b684b 100644
--- a/term-utils/write.c
+++ b/term-utils/write.c
@@ -63,6 +63,7 @@
#include "carefulputc.h"
#include "closestream.h"
#include "nls.h"
+#include "xalloc.h"
static void __attribute__ ((__noreturn__)) usage(FILE * out);
void search_utmp(char *, char *, char *, uid_t);
@@ -312,7 +313,7 @@ void do_write(char *tty, char *mytty, uid_t myuid)
char *login, *pwuid, *nows;
struct passwd *pwd;
time_t now;
- char path[PATH_MAX], host[MAXHOSTNAMELEN], line[512];
+ char path[PATH_MAX], *host, line[512];
/* Determine our login name(s) before the we reopen() stdout */
if ((pwd = getpwuid(myuid)) != NULL)
@@ -332,7 +333,8 @@ void do_write(char *tty, char *mytty, uid_t myuid)
signal(SIGHUP, done);
/* print greeting */
- if (gethostname(host, sizeof(host)) < 0)
+ host = xmalloc(sizeof(char) * (sysconf(_SC_HOST_NAME_MAX) + 1));
+ if (gethostname(host, sysconf(_SC_HOST_NAME_MAX)) < 0)
strcpy(host, "???");
now = time((time_t *) NULL);
nows = ctime(&now);
@@ -344,6 +346,7 @@ void do_write(char *tty, char *mytty, uid_t myuid)
else
printf(_("Message from %s@%s on %s at %s ..."),
login, host, mytty, nows + 11);
+ free(host);
printf("\r\n");
while (fgets(line, sizeof(line), stdin) != NULL)
--
1.7.12.2
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
