On Thu, Sep 27, 2012 at 11:49:22AM -0400, Martin K. Petersen wrote:
> >>>>> "Lukáš" == Lukáš Czerner <lczerner@xxxxxxxxxx> writes:
>
> Lukáš> TBH this is fugly :). Also what actually is the advantage of
Yes, I agree my implementation is not too readable...
> Lukáš> doing this ? So we saved 50 lines of code for this ugliness and
> Lukáš> instead of two separate binaries we have this one hybrid and
> Lukáš> symlink. I am not sure it's worth it. Can't we just have two
> Lukáš> separate binaries ? What is the problem with that ?
>
> It's not just discard. We should also consider the zeroout and write
> same use cases. They have nothing to do with fstrim.
>
> Time to incorporate and extend Garzik's blktool, perhaps?
I have applied Lukas' implementation. It seems better to have it on
the same place like fstrim.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
