Re: [PATCH 1/3] fdisk: add guid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 21, 2012 at 09:05:43AM -0400, Davidlohr Bueso wrote:
> I honestly don't see much difference between doing it before or
> after GPT, since all the other labels need to be adapted anyway. 

 I see a difference. Why we need struct fdisk_guid in struct where we
 define DOS partition types? Why there is {0} everywhere?
 Do you want to remove all these changes later?

 Anyway, I have no problem to write the patch to split part types to
 separate per-label tables :-)

 It also seems that you're introduce a new hex codes for GPT partition
 types. It means that you want to use int16_t to address types defined
 by UUIDs.  Is it good idea? Would be better to address the types by
 numbers <1-N> as printed in the menu or directly by UUIDs?

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux