On Thu, 13 Sep 2012, Kay Sievers wrote: > Date: Thu, 13 Sep 2012 17:33:49 +0200 > From: Kay Sievers <kay@xxxxxxxx> > To: Karel Zak <kzak@xxxxxxxxxx> > Cc: Lukáš Czerner <lczerner@xxxxxxxxxx>, util-linux@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] blkdiscard: add new command > > On Thu, Sep 13, 2012 at 3:57 PM, Karel Zak <kzak@xxxxxxxxxx> wrote: > > > It's UNIX, it's not so unusual that utils do one thing and do it well ;-) > > How about looking at the sensible part of UNIX? I can provide you an > endless list of crazy ideas in UNIX if you need that. And one tool per > ioctl is certainly in that list. :) Not necessarily. blockdev(8) is meant to provide user with a tool to invoke simple block device ioctl which usually does not require any arguments (except few with one argument). Changing its format to be blockdev <options> <command> <options> and extend it would certainly take away some of the nifty simplicity of that tool. That said, there is nothing wrong with having small and simple tool doing one thing and doing it right, in fact quite the opposite - it _is_ a good thing. And BTH I am not really suggesting one tool per ioctl, but blkdiscard is sufficiently different then those found in blockdev anyway (mostly -get, few -set and one -flush). In fact thinking about it some more, I am really in favour of separate tool for this functionality. BTW since when it's wrong to have such small and simple tools instead of multiplexing everything into one blob (Core OS anyone ?:)) ? -Lukas > > Kay >
