main() expects this method to return 0 for failure and 1 for success, as the other eject_*() methods do. Add the missing comparison of ioctl() >= 0 Signed-off-by: Dave Reisner <dreisner@xxxxxxxxxxxxx> --- sys-utils/eject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys-utils/eject.c b/sys-utils/eject.c index 08af08e..84bd342 100644 --- a/sys-utils/eject.c +++ b/sys-utils/eject.c @@ -398,9 +398,9 @@ static void close_tray(int fd) static int eject_cdrom(int fd) { #if defined(CDROMEJECT) - return ioctl(fd, CDROMEJECT); + return ioctl(fd, CDROMEJECT) >= 0; #elif defined(CDIOCEJECT) - return ioctl(fd, CDIOCEJECT); + return ioctl(fd, CDIOCEJECT) >= 0; #else warnx(_("CD-ROM eject unsupported")); errno = ENOSYS; -- 1.7.11.4 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html