On August 4, 2012 at 9:33 AM Sami Kerola <kerolasa@xxxxxx> wrote: > Some editors, such as Vim with 'writebackup' mode enabled, use "atomic > save" in which the old file is deleted and a new one with the same name > created in its place. The vipw tries to detect if such happen by > looking hard temporary file link count, when it is zero reopen > temporary file by using it's path. > > Reported-by: Mantas Mikulėnas <grawity@xxxxxxxxx> > References: http://www.spinics.net/lists/util-linux-ng/msg06666.html > Signed-off-by: Sami Kerola <kerolasa@xxxxxx> > --- > login-utils/vipw.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/login-utils/vipw.c b/login-utils/vipw.c > index ed3f43b..1eeeb0d 100644 > --- a/login-utils/vipw.c > +++ b/login-utils/vipw.c > @@ -275,6 +275,18 @@ static void edit_file(int is_shadow) > > if (fstat(fileno(tmp_fd), &end)) > pw_error(tmp_file, 1, 1); > + /* Some editors, such as Vim with 'writebackup' mode enabled, > + * use "atomic save" in which the old file is deleted and a new > + * one with the same name created in its place. */ > + if (end.st_nlink == 0) { > + if (close_stream(tmp_fd) != 0) > + err(EXIT_FAILURE, _("write error")); > + tmp_fd = fopen(tmp_file, "r"); > + if (!tmp_file) > + err(EXIT_FAILURE, _("cannot open %s"), tmp_file); > + if (fstat(fileno(tmp_fd), &end)) > + pw_error(tmp_file, 1, 1); > + } > if (begin.st_mtime == end.st_mtime) { > warnx(_("no changes made")); > pw_error((char *)NULL, 0, 0); > -- > 1.7.11.4 Hi Sami, wasn't the discussion about additionally prompting the user that "the file vanished and a a new file with the same name has been created" for security reasons? We're talking about the intermediate file (in /tmp), but as it's name is visible e.g. in ps listings, I'd recommend to be cautious about it. Have a nice day, Berny -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
