Re: tests: blkid/md-raid1-part fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 31, 2012 at 07:52:55AM +0200, Bernhard Voelker wrote:
> The above mentioned test fails here (OpenSuSE-12.1 64-bit).
> 
> That's in diff/blkid/md-raid1-part:
> 
> --- /media/sdb5/berny/git/util-linux/tests/expected/blkid/md-raid1-part	2012-07-27 09:54:03.769967754 +0200
> +++ /media/sdb5/berny/git/util-linux/tests/output/blkid/md-raid1-part	2012-07-31 07:18:24.057815522 +0200
> @@ -44,7 +44,7 @@
> 
> 
>  ID_FS_VERSION=0.90.0
> -ID_PART_ENTRY_DISK=8:16
> +ID_PART_ENTRY_DISK=8:112
>  ID_PART_ENTRY_NUMBER=1
>  ID_PART_ENTRY_OFFSET=2048
>  ID_PART_ENTRY_SCHEME=dos
> @@ -56,7 +56,7 @@
> 
> 
>  ID_FS_VERSION=0.90.0
> -ID_PART_ENTRY_DISK=8:16
> +ID_PART_ENTRY_DISK=8:112
>  ID_PART_ENTRY_NUMBER=2
>  ID_PART_ENTRY_OFFSET=53248
>  ID_PART_ENTRY_SCHEME=dos
> 
> What's wrong with that minor number?

Nothing, it would be better to check if the line ID_PART_ENTRY_DISK=
is in the $TS_OUTPUT and if yes then remove the line from the output
file (e.g. by sed).

The tests should not rely on device numbers and device names -- on
another places you can found /dev/loop0 in the expected outputs...

Patches wanted :-)

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux