Re: [PATCH] tests: use ts_is_mounted in mount/regfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 27, 2012 at 11:15:16AM +0200, Bernhard Voelker wrote:
> >   $ /home/berny/ul/umount /home/berny/ul/tests/output/mount/regfile.img
> >   umount: /home/berny/ul/tests/output/mount/regfile.img: not mounted
> 
> hmm, also other tests like mount/remount are failing.
> 
> Somehow, I have the impression that TS_MOUNTPOINT should be canonicalized

 Good point.

 I have added ts_canonicalize() and improved ts_init() to use it for
 all basic paths. It's probably more robust to use realpaths everywhere.

> in function.sh in ts_init_core_env and ts_init_core_subtest_env, but on the
> other side, this would eclipse errors like the above. WDYT?

 Well, important is to detect if the filesystem is mounted. We have
 special tests for mounting by symlinks where ts_canonicalize() is not
 called for the mountpoint.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux