On Thu, Jul 26, 2012 at 12:29:41PM +0200, Davidlohr Bueso wrote: > On Thu, 2012-07-26 at 11:57 +0200, Karel Zak wrote: > > On Thu, Jul 26, 2012 at 11:29:40AM +0200, Davidlohr Bueso wrote: > > > > (a) where fdisk gets the information about the geometry from in this > > > > specific case? > > > > > > fdisk gets the information from (i) user input, (ii) what the > > > kernel/bios thinks the geometry is, with the HDIO_GETGEO ioctl and (iii) > > > by inferring it from the partition table geometry. > > > > BTW, does it make any sense to read the geometry from partition table > > if the partition table has been aligned according to the device topology > > (for example 1MiB offset and grain)? > > Hmm not really, no. In any case we got rid of the pt geometry, > __discover_system_geometry() only gets the info from the kernel. I have moved get_partition_table_geometry() to dos_probe_label() :-) It seems we need if (dos_compatible) there. It means that for MBR we still read the PT geometry ;-) Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html