Re: [PATCH] lsblk: add read-ahead column.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 24, 2012 at 04:34:33PM +0200, Milan Broz wrote:
>  misc-utils/lsblk.c |    8 ++++++++
>  1 file changed, 8 insertions(+)

Applied, thanks.

> @@ -1333,6 +1340,7 @@ int main(int argc, char *argv[])
>  			columns[ncolumns++] = COL_ROTA;
>  			columns[ncolumns++] = COL_SCHED;
>  			columns[ncolumns++] = COL_RQ_SIZE;
> +			columns[ncolumns++] = COL_RA;
>  			break;

So -t output has been changed... I have added to the man page:

  The default output as well as default output from options like
  --topology and --fs is subject to change, so whenever possible you
  should  avoid using  default  outputs  in  your scripts.  Always
  explicitly  define  expected columns by '--output columns' in
  environment where a stable output is required.

it seems that we need this in all our new utils (findmnt, lslocks,
partx, ...) where is --output option. I think it's good idea to force
users to write robust scripts :-)

Comments?

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux