On Wed, 2012-05-09 at 23:56 +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Have used it to test minixfs support with various block sizes. > Hi Vladimir, A few comments: + if (MINIX_BLOCK_SIZE % 512 || MINIX_BLOCK_SIZE < 1024 + || MINIX_BLOCK_SIZE >= 65536) + usage(); This check should be part of the switch statement, perhaps in its own function. + if (*tmp && ...) + if (fs_version != 3 && MINIX_BLOCK_SIZE != MINIX12_BLOCK_SIZE) + usage(); We should set -1/-2 options to be mutually exclusive with -B. +#define MAX_MINIX_BLOCK_SIZE 65536 Isn't the max minix block size 4096? +#define MINIX12_BLOCK_SIZE 1024 This is the minimal block size, including v3. MINIX12_ doesn't describe it well. Also, please send the patches in the body of the message - just as with the lkml. Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
