Re: mkfs.minix -3 creates incorrect and limited filesystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02.05.2012 16:52, Davidlohr Bueso wrote:
> On Wed, 2012-05-02 at 16:15 +0200, Vladimir 'φ-coder/phcoder' Serbinenko
> wrote:
>> --- util-linux-2.20.1/disk-utils/mkfs.minix.c	2011-10-11 15:23:46.000000000 +0200
>> +++ util-linux-2.20.1-mod/disk-utils/mkfs.minix.c	2012-05-02 13:56:09.993347189 +0200
>> @@ -487,7 +487,7 @@ static void setup_tables(void) {
>>  
>>  	if (fs_version == 3) {
>>  		Super3.s_log_zone_size = 0;
>> -		Super3.s_blocksize = BLOCKS;
>> +		Super3.s_blocksize = MINIX_BLOCK_SIZE;
>>  	}
>>  	else {
>>  		Super.s_log_zone_size = 0;
>> @@ -773,7 +773,7 @@ int main(int argc, char ** argv) {
>>  	if (fs_version == 3)
>>  		magic = MINIX3_SUPER_MAGIC;
>>  
>> -	if (fs_version == 2) {
>> +	else if (fs_version == 2) {
>>  		if (namelen == 14)
>>  			magic = MINIX2_SUPER_MAGIC;
>>  		else
>>
> Correct, however this is already fixed in new versions.
Ok, sorry for noise then, I've used Debian version. I've discovered this
and few other Linux and tools bugs when writing automatic tests for GRUB
fs drivers.
> Thanks,
> Davidlohr
>
>
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux