RE: [PATCH] prlimit: return proper type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'd rather have the function return a proper status and not use it than
not return anything.

Thanks,
Davidlohr

On Fri, 2011-12-09 at 10:48 +0100, Voelker, Bernhard wrote:
> Davidlohr Bueso wrote:
> 
> > The add_prlim() function's definition currently returns a bogus structure.
> 
> > -static struct prlimit *add_prlim(char *ops, struct list_head *lims, size_t id)
> > +static int add_prlim(char *ops, struct list_head *lims, size_t id)
> 
> Why not void and remove that return stmt?
> The return code is not used anywhere.
> 
> Have a nice day,
> Berny


--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux