On Tue, Dec 06, 2011 at 02:04:37PM -0500, Phillip Susi wrote:
> On 12/6/2011 1:55 PM, Davidlohr Bueso wrote:
>> I like the idea, but we should wait until your BLKPG resize patches are
>> accepted in mainline before applying here. Also, assuming they make it
>> into the kernel, this patch would break partx compilation on older
>> kernels.
>
> Indeed. I thought that util-linux was closely enough tied to the kernel
> that it didn't care about building on older kernels? I put #ifdefs
> around the code using it in parted, but didn't think it was needed for
> util-linux.
The command line (our API) should not depend on kernel features, so
we usually use fallback definitions (see for example include/blkdev.h)
in case that libc/kernel header files are too old.
> Easy enough to add them back if you think it's necessary.
This is detail ;-) I'll fix it before commit.
The more important is to have kernel part in Linus' tree...
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
