* text-utils/column.c (maketbl): Use the right starting point and the right length when zeroing new memory after xrealloc. --- Hi, I ran coverity on the latest from git and it caught part of this (the erroneous offset-by-sizeof). I noticed that the "int" should be size_t or -- better -- *lens. With the latter, there is no risk that a type change will fail to propagate to this sizeof stmt. text-utils/column.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/text-utils/column.c b/text-utils/column.c index f8fd350..79d2842 100644 --- a/text-utils/column.c +++ b/text-utils/column.c @@ -305,8 +305,8 @@ static void maketbl(wchar_t **list, int entries, wchar_t *separator) cols = xrealloc(cols, maxcols * sizeof(wchar_t *)); lens = xrealloc(lens, maxcols * sizeof(ssize_t)); /* zero fill only new memory */ - memset(lens + ((maxcols - DEFCOLS) * sizeof(ssize_t)), 0, - DEFCOLS * sizeof(int)); + memset(lens + (maxcols - DEFCOLS), 0, + DEFCOLS * sizeof(*lens)); } p = NULL; } -- 1.7.8.rc2 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
