Re: [PATCH 1/2] fdisk: don't shorten long path to disk device

[Petr Uzel <petr.uzel@xxxxxxx>]

On Wed, Oct 12, 2011 at 10:25:50AM +0200, Karel Zak wrote:
> On Mon, Oct 10, 2011 at 03:12:17PM +0200, Petr Uzel wrote:
> > fdisk/partname.c:partname() uses fixed 80 char static buffer for partition
> > name. This might be not enough if the used path to the disk device is long
> > enough, e.g.
> [...]
> > -	static char bufp[80];
> > +	char *bufp;
> 
> Hmm, after review... your idea to increase the static buffer
> size to PATH_MAX seems less invasive ;-)
> 
>  -       static char bufp[80];
>  +       static char bufp[PATH_MAX];

I agree.

Thanks,

    P.


--
Petr Uzel
IRC: ptr_uzl @ freenode

Attachment: pgpGSZ8bdXiiL.pgp
Description: PGP signature