Re: [PATCH 1/2] mountpoint: refactor exit path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 10, 2011 at 03:45:45PM -0400, Dave Reisner wrote:
> On Sun, Oct 09, 2011 at 11:12:04AM -0400, Dave Reisner wrote:
> > There's only one condition for which we declare success, but many for
> > failure. Initialize rc as failure and set to success on this single
> > condition. In all cases, jump to a label to exit instead of exiting
> > immediately. This will be used later on to ease cleanup of any heap
> > allocations.

 Well, free() before exit() is usually waste of time... but maybe we
 can think about mountpoint(1) as about libmount test application,
 then it would be nice to keep it without leaks (for example for
 valgrind).

> @Karel: I can resend this if you like.

 go ahead, thanks


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux