On Wed, Jul 20, 2011 at 10:15:13AM +0200, Sami Kerola wrote:
> >> - ioprio = strtol_or_err(optarg, _("failed to parse class data"));
> >> + ioprio = strtol_or_err(optarg, _("failed to parse priority"));
> >
> > well, the original kernel Documentation/block/ioprio.txt is talking
> > about "class data" and I think it would be better to follow kernel
> > here. Maybe one day the mask for the syscall will used for a different
> > things than only for priority...
>
> I read kernel documentation using priority, class data and level as
> synonyms. To me the `class data' is most confusing because it gets
> mixed up with `class'. As you did not like `priority' I do my last
> attempt to change the word and used `level'. How that would sound?
The 'ioprio' in the syscall:
syscall(SYS_ioprio_set, which, who, ioprio);
encodes two information:
IOPRIO_PRIO_CLASS - e.g. realtime, idle, ...
IOPRIO_PRIO_DATA - e.g. 0-7
this is reason why the docs is talking about "class" and "class data".
Anyway, merged with some minor changes and --classdata option :-)
Minor notes:
* .PP in man page within .IP block does not have the same meaning
like blank line
* I think that
-c, --class NUM
is better than
-c, --class=NUM
I have fixed this in ionice man page, but not in usage(). It would be
nice to use in all man pages and usage() functions the same syntax.
Maybe we can create any template or so to have it documented.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
