Sami, thanks for the patches, few notes:
On Thu, Jul 14, 2011 at 05:47:39PM +0200, Sami Kerola wrote:
> +++ b/include/minix.h
> @@ -1,69 +1,65 @@
> #ifndef __MINIX_H__
> #define __MINIX_H__
we usually use UTIL_LINUX prefix, so #ifndef UTIL_LINUX_MINIX_H.
> #define BLOCK_SIZE_BITS 10
> #define BLOCK_SIZE (1<<BLOCK_SIZE_BITS)
This is too generic. Please, use MINIX_ prefix.
> #define Inode (((struct minix_inode *) inode_buffer)-1)
> #define Inode2 (((struct minix2_inode *) inode_buffer)-1)
>
> #define INODE_SIZE (sizeof(struct minix_inode))
> #define INODE2_SIZE (sizeof(struct minix2_inode))
>
> -int fs_version = 1; /* this default value needs to change in a near future */
> -char *super_block_buffer, *inode_buffer = NULL;
> +static int fs_version = 1; /* this default value needs to change in a
> near future */
> +static char *super_block_buffer, *inode_buffer = NULL;
>
> static char *inode_map;
> static char *zone_map;
The global variables don't belong to this generic header file. The
stuff around inode_buffer, fs_version and the inline functions are
specific to the disk-utils/ utils. Please, add
disk-utils/minix_programs.h and use it in {mkfs,fsck}.minix.
> /* sanity checks to be sure that the FS is really minix */
> - if (sb->s_imap_blocks * MINIX_BLOCK_SIZE * 8 < sb->s_ninodes + 1)
> + if (sb->s_imap_blocks * BLOCK_SIZE * 8 < sb->s_ninodes + 1)
> return -1;
> - if (sb->s_zmap_blocks * MINIX_BLOCK_SIZE * 8 < zones -
> sb->s_firstdatazone + 1)
> + if (sb->s_zmap_blocks * BLOCK_SIZE * 8 < zones - sb->s_firstdatazone + 1)
> return -1;
No, please...
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
