On Wed, Jun 29, 2011 at 01:28:15PM -0400, Davidlohr Bueso wrote:
> disk-utils/Makefile.am | 2 +-
> disk-utils/mkfs.minix.c | 142 ++++++++++++++++++++++++++++++++++++-----------
> 2 files changed, 110 insertions(+), 34 deletions(-)
Applied with some changes, thanks.
> +static int *super_set_state_ptr(void)
> +{
> + switch (fs_version) {
> + case 3:
> + Super3.s_state |= MINIX_VALID_FS;
> + Super3.s_state &= ~MINIX_ERROR_FS;
> + break;
> + default:
> + Super.s_state |= MINIX_VALID_FS;
> + Super.s_state &= ~MINIX_ERROR_FS;
> + break;
> + }
[...]
> + int *state = super_set_state_ptr();
This does not make sense. The function does not return anything and
the 'int *state' is not used. Fixed (but not tested), see the git
repository.
It would be nice to have tests/ts/minix/mkfs-v{2,3} ;-)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
