On Thu, Jun 30, 2011 at 10:53:27AM +0200, Olaf Hering wrote:
> On Thu, Jun 30, Marc-Antoine Perennou wrote:
>
> > Fix regression from commit 4aa9d65bfa76afd0d886ca410ae83428a490d4ea
> >
> > Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@xxxxxxxxxxxx>
> > ---
> > term-utils/Makefile.am | 10 ++++++++--
>
> > - chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
> > $(DESTDIR)$(usrbin_execdir)/write
> > - chmod g+s $(DESTDIR)$(usrbin_execdir)/wall
> > $(DESTDIR)$(usrbin_execdir)/write
> > +if BUILD_WALL
> > + chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
>
> This is wrong and should part of the packaging system, not part of make
> install. The userid building util-linux is not neccessary part of the
> tty group.
Why do you expect that everyone uses any packaging system? The "make
install" result should be usable. Note that this all is controlled by
--disable-makeinstall-chown and --disable-makeinstall-setuid options.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
