On Tue, Jun 14, 2011 at 13:29, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Mon, Jun 06, 2011 at 09:07:19PM +0200, Sami Kerola wrote:
>> + if ((unsigned long) pno+4 >= ARRAY_SIZE(z->partitions)) {
>
> Why 'unsigned long'? I guess that ARRAY_SIZE returns size_t. Maybe it
> would be better to use size_t for partno numbers rather than add the
> cast.
Yes are right, that was silly. I reviewed the patch and changed data
types to size_t. The fix is pushed with force to my git.
p.s. The style in the file is really horrible. How about doing the
following, which will unify the style within the file without changing
everything.
indent -linux -i4 -psl -brf sfdisk.c
--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
