On Thu, 2011-06-02 at 13:33 +0200, Karel Zak wrote: > On Wed, Jun 01, 2011 at 06:32:56PM -0400, Davidlohr Bueso wrote: > > Unite common features and code present in mkfs.minix and fsck.minix > > into a single minix.h header. > > All three patches applied, but... > > CC fsck.minix.o > In file included from fsck.minix.c:105:0: > minix.h: In function âinode_blocksâ: > minix.h:126:16: warning: unused variable âretâ > fsck.minix.c: In function âmap_block2â: > fsck.minix.c:467:9: warning: array subscript is above array bounds > CC ismounted.o > CCLD fsck.minix > CC mkfs.minix.o > In file included from mkfs.minix.c:76:0: > minix.h: In function âinode_blocksâ: > minix.h:126:16: warning: unused variable âretâ > > > ... I guess you will fix these warnings in some next cleanup patches. > The array subscript warning is old, here's a patch that silences the unused variable one. I will look into the first shortly. From: Davidlohr Bueso <dave@xxxxxxx> Date: Mon, 6 Jun 2011 09:48:25 -0400 Subject: [PATCH] minix: fix warning This patch fixes an unused variable warning. Signed-off-by: Davidlohr Bueso <dave@xxxxxxx> --- disk-utils/minix.h | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/disk-utils/minix.h b/disk-utils/minix.h index 4e670ba..0ebaa26 100644 --- a/disk-utils/minix.h +++ b/disk-utils/minix.h @@ -123,8 +123,6 @@ static inline unsigned long get_max_size(void) static unsigned long inode_blocks(void) { - unsigned long ret; - if (fs_version == 2) return UPPER(get_ninodes(), MINIX2_INODES_PER_BLOCK); else -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html