Re: [PATCH 4/7] column.c: make table function clarification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 19, 2011 at 11:06:27PM +0200, Sami Kerola wrote:
> On Tue, May 3, 2011 at 11:20, Karel Zak <kzak@xxxxxxxxxx> wrote:
> > Note, you don't have to resend all series of the patches (just
> > this one only), I'll pull from your git repository. Thanks!
> 
> Should be available via, and the branch is `column'. Usage of

 Merged. I have also fixed some bugs:

 column.c: In function âinputâ:
 column.c:350:5: warning: âlocal_listâ is used uninitialized in this
 function
 column.c: In function âmainâ:
 column.c:112:7: warning: âtermwidthâ may be used uninitialized in
 this function

> return is made to look like statement instead of function. Rest
> of the fixes follow this email, including tests very basic
> columnn regression tests which are new.

 Cool! I love regression tests.
 
 And I already found a bug by your tests. The 'maxlength' must be
 initialized, otherwise the input() function is called with some
 random numbers...  Fixed.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux