Re: [PATCH 1/3] fdisk: accept lowercase K/M/G suffixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 18, 2011 at 05:55:34PM +0200, Francesco Cosoleto wrote:
> Hi,
> 
> 2011/5/10 Karel Zak <kzak@xxxxxxxxxx>:
> >> These suffixes were accepted in previous fdisk versions but with
> >> a different meaning.
> >
> > ÂOh.. then it seems like a bad idea to apply this patch.
> >
> >> Presumably some users are inclined not to use shift key here even if
> >> this isn't the expected way to write these units.
> >
> > Âpremature optimization
> >
> > ÂKb, kB, KiB, .... all this is mess, and provide more alternatives for
> > Âthe mess is only bigger mess.
> 
> Do you think it would be clearer if fdisk prints a message after the
> dialog, something like:
> 
>  Last sector, +sectors or +size{K,M,G} (2048-125045423, default 125045423): +40G
>  A partition of 40 GiB is set.

 The message after the dialog is a good idea. (Note, see
 size_to_human_string() in  lib/strutils.c.)

> and 'K' lower-case removed or replaced with an error message?

 All currently supported suffixes have to be supported for backward
 compatibility and I don't think that we need any new suffixes.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux